Move removal of bool++ from C++14 compatibility annex to C++17 annex #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit message should start with "[compatibility]". (That can be fixed in merging, but it would expedite the process if you amended it yourself.) |
|
Thanks - my first pull request and I was not aware of the conventions, are they documented somewhere that I missed? |
|
I don't think so, but that's the format used in most of the existing commit log messages. |
|
OK, I'll check the log for precedent and update my commit message when I'm home from the office tonight. I'd rather clean this up myself now, so I am better educated for future pull requests. |
…ex to C++17 annex This change was clearly introduced in C++17, at the same meeting as removing the meaning of the register keyword. I can see no Core issue tied to this removal being resolved as a DR against 14 or earlier. I have confirmed that paper p0002r1 applied this to the C++17 annex, but was listed as a change in annex D rather than clause 5 - the latter change seeming the consistent editorial policy for removed Core features, so retained.
AlisdairM
force-pushed
the
bool_plusplus_in_17
branch
from
fe4679f
to
f44bf31
Compare
|
OK, following the log, I may have got it wrong again, but I retitled with the stable-ref of the clause that I changed - better? |
|
Looks great, thanks! |
zygoloid
added a commit
that referenced
this pull request
Mar 18, 2016
[diff.cpp11.expr] Move removal of bool++ from C++14 compatibility annex to C++17 annex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was clearly introduced in C++17, at the same meeting
as removing the meaning of the register keyword. I can see no
Core issue tied to this removal being resolved as a DR against
14 or earlier.
I have confirmed that paper p0002r1 applied this to the C++17
annex, but was listed as a change in annex D rather than clause
5 - the latter change seeming the consistent editorial policy
for removed Core features, so retained.