Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mdspan.extents.cons] Fix typo (dynamic_rank => rank_dynamic) #6461

Merged
merged 1 commit into from Apr 20, 2024
Merged

[mdspan.extents.cons] Fix typo (dynamic_rank => rank_dynamic) #6461

merged 1 commit into from Apr 20, 2024

Conversation

cpplearner
Copy link
Contributor

There's no definition of dynamic_rank. Based on the context, it seems that rank_dynamic is meant.

cc @crtrott

@cpplearner cpplearner changed the title Fix typo (dynamic_rank => rank_dynamic) [mdspan.extents.cons] Fix typo (dynamic_rank => rank_dynamic) Aug 18, 2023
@cpplearner
Copy link
Contributor Author

ping

@jensmaurer
Copy link
Member

@jwakely , this looks reasonable to me. What do you think?

@jwakely jwakely merged commit 0ac38fd into cplusplus:main Apr 20, 2024
2 checks passed
@cpplearner cpplearner deleted the main-1 branch April 20, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpplearner @jensmaurer @jwakely