Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dcl.attr.noreturn] Remove redundant note #6471

Closed

Conversation

Eisenwave
Copy link
Contributor

@Eisenwave Eisenwave commented Aug 19, 2023

This note is completely unnecessary, because just a few lines down, example 1 demonstrates:

[[ noreturn ]] void f() {
  throw "error";                // OK
}

There is no good motivation for the reader to be informed in prose that throwing in a [[noreturn]] function is okay, if the example demonstrates that.

@jensmaurer
Copy link
Member

I disagree.

Sometimes, both a note and an example are useful to drive a point home.

In any case, both notes and examples are non-normative, and we sprinkle notes around if we feel they're helpful (as long as they're not wrong).

I'm not seeing any argument that the note is outright wrong, just that it is redundant, but the latter is exactly the purpose of notes.

@jensmaurer jensmaurer closed this Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants