Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[format.string.std]/4: sC example doesn't have enough clowns #6474

Closed
timsong-cpp opened this issue Aug 19, 2023 · 4 comments · Fixed by #6531
Closed

[format.string.std]/4: sC example doesn't have enough clowns #6474

timsong-cpp opened this issue Aug 19, 2023 · 4 comments · Fixed by #6531

Comments

@timsong-cpp
Copy link
Contributor

draft/source/utilities.tex

Line 15920 in a272b7c

string sC = format("{:*@\caret{}@6}", "@\importexample[-2pt]{example_05}@"); // value of \tcode{sC} is \tcode{"\importexample[-2pt]{example_05}\importexample[-2pt]{example_05}\importexample[-2pt]{example_05}"}

The string being formatted should have three clowns, not one.
@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 23, 2023

@tahonermann Could you have a look and verify this bug?

@JohelEGP
Copy link
Contributor

Is the DIS correct?
You promised: #6144 (comment).
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p2572r1.html#wording
does mention
1692804184
which the motion's PR was unable to add.

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 23, 2023

Seems like there was indeed not enough clownery :-(

@tahonermann
Copy link
Contributor

Good catch, @timsong-cpp . @tkoeppe had asked me to verify that the DIS looked right quite some time ago and I confirmed it did. Alas, I was apparently so excited to see clowns at all that I neglected to count them :(

It looks like there are some FIXME comments that can probably be removed when correcting this:

@tkoeppe tkoeppe mentioned this issue Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[format.string.std] Fix example tkoeppe/draft
4 participants
@tahonermann @tkoeppe @timsong-cpp @JohelEGP