[class.conv.ctor] Turn last paragraph into a note #6505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensdh
reviewed
Nov 11, 2023
Comment on lines
2408
to
2409
| An implicitly-declared copy/move constructor is not an explicit constructor; | ||
| it can be called for implicit type conversions. |
There was a problem hiding this comment.
This is now pretty heavily redundant. How about
A non-explicit copy/move constructor ([class.copy.ctor]), including one implicitly declared, is a converting constructor.
There was a problem hiding this comment.
@Eisenwave ^^^ could you please have a look?
There was a problem hiding this comment.
Yeah I'll go through all the things I have to do in this repo tomorrow.
|
CWG 2023-11-11: Approved as-is. |
jensmaurer
added
the
after-motions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paragraph 1 already states:
draft/source/classes.tex
Lines 2347 to 2353 in 1c22d62
The reader has no reason to believe that a copy/move constructor is excluded from the rule, and it certainly doesn't need to be stated in normative wording. The whole paragraph can and should be a note.