Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rand.device] Weird text style in comment #6513

Closed
Eelis opened this issue Aug 25, 2023 · 6 comments · Fixed by #6514
Closed

[rand.device] Weird text style in comment #6513

Eelis opened this issue Aug 25, 2023 · 6 comments · Fixed by #6514

Comments

@Eelis
Copy link
Contributor

Eelis commented Aug 25, 2023

draft/source/numerics.tex

Line 3634 in 3d62863

@\textit{// no copy functions}@

This produces:

image

I'm not sure if the odd style had some intended purpose.
@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 25, 2023

There's a weird stray \textit there. Feel free to send a PR to remove it!

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 25, 2023

(It's also an overall weirdly colloquial comment.)

Eelis added a commit to Eelis/draft that referenced this issue Aug 25, 2023
@Eelis
[rand.device] Remove stray \textit.
6b2b480 
Fixes cplusplus#6513.
@Eelis Eelis mentioned this issue Aug 25, 2023
Merged
tkoeppe pushed a commit that referenced this issue Aug 25, 2023
@Eelis @tkoeppe
[rand.device] Remove stray \textit.
a54e71e 
Fixes #6513.
@jwakely
Copy link
Member

jwakely commented Aug 25, 2023

We should just remove the comment and move the declaration next to the other constructors.

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 25, 2023

I suppose this comes from a time when deleted members were new and everyone was excited to put them to use?

@jwakely
Copy link
Member

jwakely commented Aug 25, 2023

And explain them!

@JohelEGP
Copy link
Contributor

JohelEGP commented Aug 25, 2023 •
edited

The synopsis generally doesn't follow https://eel.is/c++draft/structure.specifications#2,
which may be related to #2528.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[rand.device] Remove stray \textit. Eelis/draft
4 participants
@Eelis @jwakely @tkoeppe @JohelEGP