Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add \hypertarget to enable url links into xrefs #6516

Merged
merged 1 commit into from Nov 10, 2023

Conversation

t3nsor
Copy link
Contributor

@t3nsor t3nsor commented Aug 26, 2023

Fixes #6510 .

@t3nsor
Copy link
Contributor Author

t3nsor commented Aug 26, 2023

I've built the PDF locally and tested that the following kinds of URL hash fragments do the right thing:

  • #dcl.init.general: goes to [dcl.init.general] in the main text
  • #defns.static.type: goes to the definition of "static type"
  • #implimits: goes to Annex B.

It was necessary to move the \addxref command to the beginning of the expansions that it's referenced in, to ensure that the \hypertarget targets the end of the previous line, not the end of the line that the heading is located on. So I've also checked that the glossary entries still go to the right place. It appears that they do.

@tkoeppe tkoeppe merged commit 3e1f377 into cplusplus:main Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Section headings should use \hypertarget
4 participants