Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vector.data],[array.members] Clarify C++ boolean expression #6526

Merged
merged 1 commit into from Aug 28, 2023
Merged

[vector.data],[array.members] Clarify C++ boolean expression #6526

merged 1 commit into from Aug 28, 2023

Conversation

Eisenwave
Copy link
Contributor

As far as I know, it is not enough to say

For a non-empty array, [C++ boolean expression]

It is not obvious that this should be automatically interpreted as [C++ boolean expression] is true in all cases.

This edit fixes it by explicitly saying that the expression is true, which looks to be the intention here.

jwakely
jwakely approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also just phrase it as "x is equal to y" instead of "x == y is true", but this change is correct, which is better than the current wording, thanks.

@jensmaurer jensmaurer merged commit 9a0b5d7 into cplusplus:main Aug 28, 2023
2 checks passed
@Eisenwave Eisenwave mentioned this pull request Aug 30, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eisenwave @jwakely @jensmaurer