Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusion about formatting of Cpp17 iterator requirements #6537

Open
Eisenwave opened this issue Aug 30, 2023 · 1 comment · Fixed by #6613
Open

Confusion about formatting of Cpp17 iterator requirements #6537

Eisenwave opened this issue Aug 30, 2023 · 1 comment · Fixed by #6613

Comments

@Eisenwave
Copy link
Contributor

I'm confused about how iterator requirements should be formatted.

[forward.iterators] uses no formatting at all, and says

meets the requirements of a forward iterator if

However, it simultaneously references Cpp17InputIterator which is not consistent.

[iterator.requirements.general] p14 references "non-forward iterator", but this is not a defined term because "forward iterator" isn't defined, and it also doesn't use Cpp17ForwardIterator formatting.

Overall, this is very confusing, and I don't understand the logic behind when ItalicRequirement formatting should be used, and when plain formatting, or definition formatting should be used.
@frederick-vs-ja
Copy link
Contributor

The sentence in [iterator.requirements.general] p14 was changed by P0896R4, presumably refers to both forward_iterator and Cpp17ForwardIterator. We may need an LWG issue for clarification.

In [forward.iterators] p1, I think we can editorially change " the requirements of a forward iterator" to "the Cpp17ForwardIterator requirements".

This was referenced Oct 10, 2023
Merged
Merged
@tkoeppe tkoeppe reopened this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[iterator.requirements.general] Clarify non-forward iterator frederick-vs-ja/draft
3 participants
@tkoeppe @Eisenwave @frederick-vs-ja