[mdspan] require conversion results to be nonnegative #6561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive "nonnegative" is meaningless for a value of some arbitrary type which we've only required to be convertible to the integral type `index_type`, so this wording clearly intends to constrain the result of the conversion.
|
" |
… to 0 `s[i]` is an lvalue of a type that we can only convert to `index_type`; clearly the wording intends that the result of the conversion should be `> 0`.
|
I've pushed two more commits fixing the same issue in a couple more places, with the expectation it will be easiest to review these together. The commits are fine-grained for ease of review and each follow the editorial guidelines so it should be possible to merge them cleanly without squashing. Shout if I made the wrong call and I should split these up into three PRs. |
CaseyCarter
changed the title
CaseyCarter
commented
Sep 12, 2023
[mdspan.layout.stride.cons] uses either a span or array of a type which we can only convert to `index_type` as the second argument to the exposition-only `REQUIRED-SPAN-SIZE`. We must perform that conversion before doing math with the result.
CaseyCarter
force-pushed
the
mdspan1
branch
from
e67dcff
to
819c0a1
Compare
|
I should tag @jwakely for review. I know I'm near the boundary of what qualifies as editorial, and I think I'm on the right side of that boundary, but someone more objective should judge whether LWG needs to look at this. |
jwakely
approved these changes
Sep 19, 2023
jensmaurer
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"nonnegative" is meaningless for a value of some arbitrary type which we've only required to be convertible to the integral type
index_type, so this wording clearly intends to constrain the result of the conversion.