Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdspan.layout.left] Add missing noexcept #6602

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented Oct 6, 2023

..as declaration has noexcept qualifier. Is this editorial or LWG?

@CaseyCarter
Copy link
Contributor

CaseyCarter commented Oct 6, 2023

Is this editorial or LWG?

If the Standard disagrees with the ingress paper (P0009R18) it's editorial. In this case, they agree. That generally makes it an LWG issue to determine which one is correct, unless you can present a convincing argument to the editors.

I'll point out that both layout_left::mapping::extents and the exposition-only extents::fwd-prod-of-extents are noexcept, so computing the return value extents().fwd-prod-of-extents(i) is not potentially-throwing.

@hewillk
Copy link
Contributor Author

hewillk commented Oct 7, 2023

I saw that many functions that accept indices in <mdspan> have the constraints of (is_convertible_v && is_nothrow_constructible_v). I wonder why not just simply use is_nothrow_convertible_v directly, which seems to be more accurate to me.

@hewillk
Copy link
Contributor Author

hewillk commented Nov 8, 2023

I saw that many functions that accept indices in <mdspan> have the constraints of (is_convertible_v && is_nothrow_constructible_v). I wonder why not just simply use is_nothrow_convertible_v directly, which seems to be more accurate to me.

CC @crtrott for insights.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2023

That said, if this is not an editorial misapplication of the approved paper, I would prefer if you filed an LWG issue. If you provide rationale and a resolution, it might get approved very quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants