Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[intro.scope] Clarify 'they' #6603

Merged
merged 1 commit into from Oct 8, 2023
Merged

[intro.scope] Clarify 'they' #6603

merged 1 commit into from Oct 8, 2023

Conversation

jensmaurer
Copy link
Member

Fixes ISO/CS 034 (C++23 DIS).

Fixes cplusplus/nbballot#576

@jensmaurer
[intro.scope] Clarify 'they'
59a8402 
Fixes ISO/CS 034 (C++23 DIS).
@jensmaurer jensmaurer added the ballot-comment Response to an NB or ISO comment on a ballot label Oct 7, 2023
@jensmaurer jensmaurer added this to the C++23 milestone Oct 7, 2023
jwakely
jwakely approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems fine to me, but if we wanted to avoid "an implementation implements" we could also say "The first such requirement on implementations is that they implement the language" which makes it clear who "they" are.

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 8, 2023 •
edited

@jensmaurer Thoughts on Jon's idea? It's perhaps a little smoother.

@jensmaurer
Copy link
Member Author

I've had my suggestion approved by the CWG telecon on Friday, and everybody present felt that "they" was unambiguously referring to the first preceding plural, and thus the comment was unwarranted.

Given the general fluffiness of the text here, I feel I shouldn't deviate from CWG's approved approach.

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 8, 2023

Make sense, thanks!

@tkoeppe tkoeppe merged commit bd7f9a9 into cplusplus:main Oct 8, 2023
2 checks passed
@jensmaurer jensmaurer deleted the dis34 branch October 8, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

Assignees
No one assigned
Labels
ballot-comment Response to an NB or ISO comment on a ballot
Projects
None yet
Milestone
C++23
Development

Successfully merging this pull request may close these issues.

**-034 [intro.scope] Unclear meaning "they"
3 participants
@jensmaurer @tkoeppe @jwakely