Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[type.traits] Add references to tables #6609

Merged
merged 1 commit into from Oct 13, 2023
Merged

[type.traits] Add references to tables #6609

merged 1 commit into from Oct 13, 2023

Conversation

jensmaurer
Copy link
Member

Fixes ISO/CS 001 (C++23 DIS).

Fixes cplusplus/nbballot#543

@jensmaurer jensmaurer added the ballot-comment Response to an NB or ISO comment on a ballot label Oct 8, 2023
@jensmaurer jensmaurer added this to the C++23 milestone Oct 8, 2023
@jensmaurer
Copy link
Member Author

@jwakely , @CaseyCarter , this contains quite a bit of new text. Please have a look.

@jensmaurer
[type.traits] Add references to tables
bc0442b 
Fixes ISO/CS 001 (C++23 DIS).
CaseyCarter
CaseyCarter approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tkoeppe tkoeppe merged commit 4676f76 into cplusplus:main Oct 13, 2023
2 checks passed
@jensmaurer jensmaurer deleted the dis01 branch October 13, 2023 21:01
jwakely
jwakely reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely left review comments

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees
No one assigned
Labels
ballot-comment Response to an NB or ISO comment on a ballot
Projects
None yet
Milestone
C++23
Development

Successfully merging this pull request may close these issues.

**-001 [meta] Missing reference to tables
4 participants
@jensmaurer @CaseyCarter @jwakely @tkoeppe