Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iterator.requirements.general] Clarify non-forward iterator #6613

Merged
merged 1 commit into from Nov 9, 2023
Merged

[iterator.requirements.general] Clarify non-forward iterator #6613

merged 1 commit into from Nov 9, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #6537.

Not sure whether the clarification can be done editorially.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 8, 2023

I would welcome some LWG review here, @jwakely, @CaseyCarter

@tkoeppe tkoeppe added the lwg Issue must be reviewed by LWG. label Nov 8, 2023
jwakely
jwakely approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. The pointers and references must outlive the iterator if either of the conditions is true, so they can be invalidated only if both are false.

jensmaurer
jensmaurer approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok

@tkoeppe tkoeppe merged commit 8b38857 into cplusplus:main Nov 9, 2023
2 checks passed
@frederick-vs-ja frederick-vs-ja deleted the destroy-non-forward branch November 9, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
lwg Issue must be reviewed by LWG.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusion about formatting of Cpp17 iterator requirements
4 participants
@frederick-vs-ja @tkoeppe @jwakely @jensmaurer