Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[defns.{impl.limits,iostream.templates}] Use singular #6614

Merged
merged 1 commit into from Oct 10, 2023
Merged

[defns.{impl.limits,iostream.templates}] Use singular #6614

merged 1 commit into from Oct 10, 2023

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Oct 10, 2023

Also change "argument" to "parameter" in the note.

Fixes ISO/CS 015 (C++23 DIS).

Fixes cplusplus/nbballot#557

jensmaurer
jensmaurer approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just delete "iostream class template" going forward; it's only mentioned in a note that doesn't need to be super-precise.

But in the interim, what we have here is good.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Oct 10, 2023

Let's see how that other discussion goes. I wasn't sure whether we'll delete or repair.

@tkoeppe
[defns.{impl.limits,iostream.templates}] Use singular
ac456b5 
Also change "argument" to "parameter" in the note.

Fixes ISO/CS 015 (C++23 DIS).
@tkoeppe tkoeppe merged commit d358d34 into cplusplus:main Oct 10, 2023
2 checks passed
@tkoeppe tkoeppe deleted the singular branch October 10, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

**-015 3.28, 3.29 Defined terms should be singular
3 participants
@tkoeppe @CaseyCarter @jensmaurer