Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[intro.object] For object names, don't refer to 'name' grammar rule, … #662

Merged
merged 1 commit into from Mar 24, 2016

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Mar 24, 2016

…because that one is from [path.generic].

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 24, 2016

Surely the right thing would be to fix the filesystem grammar name rather than meddle with the fundamental object model?

Also, why doesn't the filesystem grammar get indexed? Maybe it's missing from the list of indexable files.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 24, 2016

Oh, I see, the grammar in iostreams.tex is "non-copied". In that case I think this is NAD.

@Eelis
Copy link
Contributor Author

Eelis commented Mar 24, 2016

The thing is, as far as I can see, there is no "name" grammar rule other than the one in [path.generic]. So even if we convince ourselves that it doesn't really refer to that one, then what does it refer to? :)

@jwakely
Copy link
Member

jwakely commented Mar 24, 2016

For consistency with the rest of the paragaph it should use \term{name}, rather than simply dropping all formatting from that word.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 24, 2016

Yes, I can see that. Maybe the commit should be phrased like 5c8435c

@jwakely
Copy link
Member

jwakely commented Mar 24, 2016

And clearly it refers to the definition of "name" in Clause 3, as indicated by the cross-reference.

@Eelis
Copy link
Contributor Author

Eelis commented Mar 24, 2016

Thanks, that makes sense. Updated branch

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 24, 2016

Much better, thanks!

@jwakely jwakely merged commit 342c5d1 into cplusplus:master Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants