Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[streambuf.general] std::basic_streambuf is not an abstract class #6629

Closed
PJBoy opened this issue Oct 19, 2023 · 2 comments · Fixed by #6630
Closed

[streambuf.general] std::basic_streambuf is not an abstract class #6629

PJBoy opened this issue Oct 19, 2023 · 2 comments · Fixed by #6630

Comments

@PJBoy
Copy link
Contributor

PJBoy commented Oct 19, 2023

p1 says "The class template basic_streambuf serves as an abstract base class for deriving various stream buffers". Base class I agree with, but an abstract class has a pure virtual function, and basic_streambuf has not
@timsong-cpp
Copy link
Contributor

This is LWG2504.

@jensmaurer
Copy link
Member

I think this is sufficiently obvious that we can handle this editorially.

I'd suggest to simply strike "abstract" here; this is an intro sentence that doesn't need to show the full picture.

Pull request welcome.

PJBoy added a commit to PJBoy/C--draft that referenced this issue Oct 21, 2023
@PJBoy
[streambuf.general] Strike "abstract" from "basic_streambuf serves as…
2ce0004 
… an abstract base class" (issue cplusplus#6629)
@PJBoy PJBoy mentioned this issue Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@PJBoy @timsong-cpp @jensmaurer