Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[span.cons] Add std:: for data(arr) #6632

Merged
merged 1 commit into from Oct 24, 2023
Merged

[span.cons] Add std:: for data(arr) #6632

merged 1 commit into from Oct 24, 2023

Conversation

cpplearner
Copy link
Contributor

std::span has a member function data, which shadows std::data.

It is especially awkward that in data() == data(arr), the first data refers to the member, while the second refers to std::data. The addition of std:: helps to clarify that these two data belong to different scopes.

@jensmaurer jensmaurer merged commit a27ede6 into cplusplus:main Oct 24, 2023
2 checks passed
@cpplearner cpplearner deleted the patch-3 branch October 24, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpplearner @jwakely @jensmaurer