[mdspan.submdspan] Add missing definitions for full_extent_t and full_extent #6643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CaseyCarter, @jwakely, could you please have a look? |
|
I'm not sure whether it's desired to handle a batch of resolutions of LWG issues in a concentrated PR. If so, we should add definitions in that PR and close this. |
|
Duplicate of #6353. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempt to fix an oversight in P2630R4 (submdspan) that was voted into the draft in Varna.
full_extent_tis the tag type that represents all indices.full_extentis a constant of typeconst full_extent_twhich can be passed as a slice specifier argument tosubmdspan().full_extent_tis used 8x in [mdspan.submdspan].full_extentis used in the code snippet (Example 1) in the last paragraph.Neither is ever defined.
These can be found in the wording of P0009R16 but were removed in R17 for the sake of
mdspanmaking it into C++23.@jwakely
@crtrott
@tkoeppe