Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Motions 2023 11 cwg 3] P2662R3 Pack Indexing #6679

Merged
merged 2 commits into from
Dec 17, 2023
Merged

[Motions 2023 11 cwg 3] P2662R3 Pack Indexing #6679

merged 2 commits into from
Dec 17, 2023
+140 −15

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented Nov 12, 2023 •
edited
Loading

Fixes #6657
Fixes cplusplus/papers#1329

NOTE:

  • The paper renames class-or-decltpye to class-or-computed-type-specifier
    in the grammar, but nowhere else. There are references to class-or-decltype
    in the narrative accompanying the grammar, those references are now pointing
    to nowhere.

It is editorially-unclear whether the other mentions of class-or-decltype
should be bluntly replaced, or whether some of them shouldn't (maybe
because of special cases).

  • In expr.prim.id.qual, an "or" was struck, but nothing was added.
    The only effect is to destroy the grammar of the sentence.
    This can be editorially reverted, I think.

@jensmaurer jensmaurer force-pushed the motions-2023-11-cwg-3 branch from 8f02007 to 6c54ab1 Compare November 12, 2023 21:30
@jensmaurer jensmaurer changed the title P2662R3 Pack Indexing CWG Motion 3: P2662R3 Pack Indexing Nov 12, 2023
@jensmaurer jensmaurer added this to the post-2023-11 milestone Nov 12, 2023
@jensmaurer jensmaurer force-pushed the motions-2023-11-cwg-3 branch from 6c54ab1 to 397c0d8 Compare November 12, 2023 21:56
JohelEGP
JohelEGP suggested changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used https://isocpp.org/files/papers/P2662R3.pdf.

@jensmaurer jensmaurer changed the title CWG Motion 3: P2662R3 Pack Indexing [Motions 2023 11 cwg 3] P2662R3 Pack Indexing Nov 15, 2023
@cor3ntin
Copy link
Contributor

In expr.prim.id.qual, an "or" was struck, but nothing was added.
The only effect is to destroy the grammar of the sentence.
This can be editorially reverted, I think.

Yes, mistake on my part

The paper renames class-or-decltpye to class-or-computed-type-specifier
in the grammar, but nowhere else. There are references to class-or-decltype
in the narrative accompanying the grammar, those references are now pointing
to nowhere.

I did review all use of class-or-decltype and they can all be replaced afaict.

@jensmaurer
Copy link
Member Author

jensmaurer commented Nov 16, 2023 •
edited
Loading

I did review all use of class-or-decltype and they can all be replaced afaict.

That may or may not be the case; I can't see such a replacement to be editorial (since we change what those places mean). Or did I miss a blanket instruction in the paper to perform the replacement?

@jensmaurer jensmaurer force-pushed the motions-2023-11-cwg-3 branch from d76d570 to c29ac0a Compare November 16, 2023 13:05
@burblebee burblebee requested a review from JohelEGP November 17, 2023 06:00
@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Nov 22, 2023
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Nov 22, 2023
@tkoeppe tkoeppe force-pushed the motions-2023-11-cwg-3 branch 2 times, most recently from f60d475 to 7f3353b Compare December 17, 2023 01:51
jensmaurer and others added 2 commits December 17, 2023 01:54
@jensmaurer @tkoeppe
P2662R3 Pack Indexing
a60e1c5 
Editorial note: the proposed solitary change to strike the word "or"
from [expr.prim.id.qual] has not been applied, since it seemed
incorrect and inappropriate.
@tkoeppe
[class.derived.general] Revert renaming of grammar production
c831ec0 
P2662R3 "Pack Indexing" proposed to rename the grammar production
"class-or-decltyp" to "class-or-computed-type-specifier", without
making matching changes elsewhere in the text.

Since that change would break the existing wording and does not
otherwise seem to have an beneficial effects, we are reverting it for
the moment and await clarification.
@tkoeppe tkoeppe force-pushed the motions-2023-11-cwg-3 branch from 7f3353b to c831ec0 Compare December 17, 2023 01:58
@tkoeppe tkoeppe merged commit 3f1be09 into main Dec 17, 2023
@jensmaurer jensmaurer deleted the motions-2023-11-cwg-3 branch March 23, 2024 11:45
@cor3ntin
Copy link
Contributor

cor3ntin commented May 11, 2024 •
edited
Loading

@jensmaurer @tkoeppe I just realized that the wording on top of page 18 does not seem to have been applied
Ie the grammar of base-specifier was not modified.

@jensmaurer
Copy link
Member Author

jensmaurer commented May 11, 2024 •
edited
Loading

The current state for the name class-or-decltype is intentional; see c831ec0 .

However, in the production class-or-decltype, the change from decltype-specifier to computed-type-specifier was incorrectly reverted by the above change.

Fixed by #6969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohelEGP JohelEGP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2023-11
Development

Successfully merging this pull request may close these issues.

[2023-11 CWG Motion 3] Pack Indexing P2662 R3 Pack Indexing
5 participants
@jensmaurer @cor3ntin @JohelEGP @tkoeppe @wg21bot