Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Motions 2023 11 cwg 4] P2864R2 Remove deprecated arithmetic conversions #6683

Merged
merged 1 commit into from Dec 17, 2023

Conversation

AlisdairM
Copy link
Contributor

@AlisdairM AlisdairM commented Nov 13, 2023

source/expressions.tex Outdated Show resolved Hide resolved
source/compatibility.tex Outdated Show resolved Hide resolved
source/compatibility.tex Outdated Show resolved Hide resolved
@AlisdairM AlisdairM changed the title Apply P2864R2 Remove deprecated arithmetic conversions [Motions 2023 11 cwg 4] P2864R2 Remove deprecated arithmetic conversions Nov 14, 2023
@jensmaurer jensmaurer added this to the post-2023-11 milestone Nov 15, 2023
@burblebee
Copy link
Contributor

@AlisdairM, your changes look good other than:

  • Your wording changes to the \effect clause diverge a bit much from the paper. At the very least, this divergence should have been included with the initial commit comment and explained, but preferably, a change this great from the original wording should have been done in a separate commit.
  • As Johel mentioned, you're missing the wording for \difficulty.
  • The commit comments for changes which should have been included in the original commit (i.e. your fixes to what Johel found) should be prefixed with "FIXUP" so that the editor knows to squash these before merging. e.g. your "Update source/compatibility.tex" comments should have been something like "FIXUP: Add missing punctuation after "Uncommon".

@tkoeppe tkoeppe force-pushed the motions-2023-11-cwg-4 branch 2 times, most recently from 9715b14 to 663e6ff Compare December 17, 2023 02:08
source/compatibility.tex Outdated Show resolved Hide resolved
@tkoeppe tkoeppe merged commit db09152 into cplusplus:main Dec 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants