Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[error.reporting] references in [filesystems] should be to [fs.err.report] instead #669

Closed
timsong-cpp opened this issue Mar 30, 2016 · 6 comments
Assignees

Comments

@timsong-cpp
Copy link
Contributor

[filesystems] contains numerous references to [error.reporting]; they should be to [fs.err.report].

@jwakely jwakely self-assigned this Mar 31, 2016
@jwakely
Copy link
Member

jwakely commented Mar 31, 2016

We might need to check all the cross-references. In [fs.conform.9945] we have:

Some behavior is specified by reference to POSIX (27.10.2.1).

But 27.10.2.1 is [fs.conform.9945]. The href in the HTML is correct, pointing to [fs.norm.ref], so the LaTeX is correct.

However, later in [fs.conform.9945] we have:

the implementation shall report an error as specified in § 27.10.7.

Which is the correct number, but this time the HTML href points to [fs.norm.ref] when it should be [fs.err.report].

@jwakely
Copy link
Member

jwakely commented Mar 31, 2016

[path.construct]/4 refers to 27.10.8.2.1 but the exact same requirement in [path.assign]/5 refers to 27.10.8.2.2 but with the text 27.10.8.2.1

Same problem in [path.append]/5 and /6 and [path.concat]/1

I assume all should be to 27.10.8.2, the parent section that covers both format and encoding, rather than flip-flopping between the two.

@jwakely
Copy link
Member

jwakely commented Mar 31, 2016

There are some inline cross-references too, which were lost in the conversion to LaTeX, such as "native pathname format" in [path.native.obs]p1 and "resolve" in [path.non-member]p10. The former is easy to fix but I'm not sure what the latter is referencing.

Also "file system races" in [fs.op.funcs]p1, "absolute path" in [fs.op.absolute]p1, both easy to fix.

@jwakely
Copy link
Member

jwakely commented Mar 31, 2016

The original issue is fixed by afae63c

The flip-flopping references for format and encoding conversion are fixed by 5d086be

The inline html links have been re-inserted by 4ecda29, e3c65c8, and 6513551.

The "resolve" link is still absent.

@jwakely jwakely closed this as completed Mar 31, 2016
@jwakely
Copy link
Member

jwakely commented Apr 5, 2016

Oops, I only pushed those commits to my own fork.

@jwakely jwakely reopened this Apr 5, 2016
@jwakely
Copy link
Member

jwakely commented Apr 5, 2016

Fixed now, the updated commit IDs are:

6513551 [path.op.absolute] Add cross-reference to [fs.def.absolute.path].
e3c65c8 [path.op.funcs] Add cross-reference to [fs.def.race].
4ecda29 [path.native.obs] Add cross-reference to [fs.def.native].
5d086be [path.construct], [path.assign], [path.append], [path.concat] Change references to [path.cvt].
afae63c [filesystems] Fix references to [fs.err.report].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants