Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LWG 18] P2264R7 Make assert() macro user friendly for C and C++ #6701

Merged
merged 1 commit into from Dec 17, 2023

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Nov 16, 2023

Fixes #6676.
Fixes cplusplus/papers#957

Question: Was the red wording in [cassert.syn] intended to be deleted?

  • Update: Thomas says no; added back and force-pushed.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 16, 2023

Sorry, I already discussed that with Peter and @jwakely during the meeting: the formatting is a bit confusing; the red parentheses are just syntax highlighting, but unaffected; the only edit is the strikethrough (the E).

(I've asked Jon to ask authors for better edit instructions in the future.)

@jensmaurer jensmaurer added this to the post-2023-11 milestone Nov 16, 2023
@burblebee
Copy link
Contributor Author

@tkoeppe Who's responsible for our build machines? The Macs don't appear to be set up correctly, and when they fail, they appear to cancel the Linux build, so no way to get a final build. Would be nice if we didn't cancel the Linux build at least - where's the source for this?

@burblebee burblebee marked this pull request as ready for review November 16, 2023 22:36
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 16, 2023

Yes, sorry, the macs aren't terribly reliable. I normally just press "restart all" on the check, it usually works most of the time.

I'm not sure who's responsible -- someone at GitHub? I don't think the runners come with any kind of guarantees, though.

@tkoeppe tkoeppe force-pushed the motions-2023-11-lwg-18 branch 2 times, most recently from 0dd4282 to 24c3d5e Compare December 17, 2023 22:41
@tkoeppe tkoeppe merged commit 64ad91d into main Dec 17, 2023
4 checks passed
@jensmaurer jensmaurer deleted the motions-2023-11-lwg-18 branch March 23, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants