Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LWG 16] P2833R2 Freestanding Library: inout expected span #6703

Merged
merged 1 commit into from Dec 17, 2023

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Nov 17, 2023

Partially fixes #6674.

Note:

  • See [LWG 10] P2821R5 span.at() #6692 for change to [views.span] after [P2821] "span.at()" merged: "append a // freestanding-deleted comment to every overload of at". I only saw one such "overload" - should there be more?

@burblebee burblebee marked this pull request as ready for review November 17, 2023 00:13
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're only missing this instruction,
because this PR doesn't have std::span::at:

Changes in [views.span]

Drafting note: Only apply this change if [P2821] "span.at()" has been merged.

Please append a // freestanding-deleted comment to every overload of at.

@burblebee
Copy link
Contributor Author

We're only missing this instruction, because this PR doesn't have std::span::at:

Changes in [views.span]
Drafting note: Only apply this change if [P2821] "span.at()" has been merged.
Please append a // freestanding-deleted comment to every overload of at.

See Note in comment at top - that was added to #6692.

@jwakely
Copy link
Member

jwakely commented Nov 17, 2023

should there be more?

There should only be one.

@tkoeppe tkoeppe merged commit 9e69991 into main Dec 17, 2023
4 checks passed
@jensmaurer jensmaurer deleted the motions-2023-11-lwg-16 branch March 23, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2023-11 LWG Motion 16] Freestanding Library: inout expected span
4 participants