Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated templates.tex to make program ill formed when the set of func… #6706

Closed
wants to merge 1 commit into from

Conversation

ranaanoop
Copy link
Contributor

…tion templates considered is empty

Related to CWG-issue-465 that notes that currently there is implementation divergence for the friend declaration friend void fun2<T>(typename Ext<T>::Inner&); when there is no forward declaration of any such func2 function template. The edit is suppose to clarify that temp.deduct.decl#2 clause makes the program ill-formed.

…tion templates considered is empty

Related to [CWG-issue-465](cplusplus/CWG#465) that notes that currently there is [implementation divergence](https://godbolt.org/z/v86Ga7Mrj) for the friend declaration `friend void fun2<T>(typename Ext<T>::Inner&);` when there is no forward declaration of any such `func2` function template. The edit is suppose to clarify that [temp.deduct.decl#2](https://timsong-cpp.github.io/cppwp/n4868/temp.deduct.decl#2) clause makes the program ill-formed.
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem editorial. Shouldn't this go through CWG first?

@ranaanoop
Copy link
Contributor Author

This doesn't seem editorial. Shouldn't this go through CWG first?

@jwakely It was suggested that it may be an editorial issue so I created a pull request. Personally, It does seem to be non-editorial to me too.

@jwakely
Copy link
Member

jwakely commented Nov 17, 2023

The suggestion was to add a note, which would be editorial. But if a normative change is needed, that's not editorial.

@jensmaurer jensmaurer added cwg Issue must be reviewed by CWG. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking. labels Nov 17, 2023
@jensmaurer
Copy link
Member

This is not the correct approach, I think. Don't merge.

@ranaanoop ranaanoop closed this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cwg Issue must be reviewed by CWG. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants