Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[std] Update references from ISO 8601:2004 to ISO 8601-1:2019 #6720

Merged
merged 1 commit into from Dec 7, 2023

Conversation

jensmaurer
Copy link
Member

As requested by ISO/CS for C++23 DIS.

@jensmaurer jensmaurer marked this pull request as ready for review December 5, 2023 16:27
@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 6, 2023

@Dani-Hub Could you please take a look? Jens looked up the new subclause number in the table of contents.

@Dani-Hub
Copy link
Member

Dani-Hub commented Dec 6, 2023

I wonder whether referring to 5.3.4.1 alone is too limited. I suggested 5.3.4 because it contains both 5.3.4.1 and 5.3.4.2, where the latter additionally explains how to combine the time of day in the presence of a time shift between local time and UTC. But I acknowledge that this part may not be needed for %z.

@jensmaurer
Copy link
Member Author

where the latter additionally explains how to combine the time of day in the presence of a time shift between local time and UTC.

Nowhere do we discuss the combination in C++. %z just has the offset, which is defined in 5.3.4.1.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 6, 2023

Great, thank you, both!

@tkoeppe tkoeppe merged commit f519ea4 into main Dec 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants