Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[std] Rephrase notes containing 'must' #6737

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jensmaurer
Copy link
Member

Fixes ISO/CS 037 (C++23 DIS).

Fixes cplusplus/nbballot#579

@jensmaurer jensmaurer added this to the C++23 milestone Dec 17, 2023
@jensmaurer
Copy link
Member Author

@tkoeppe , this is an initial sample of what might be done. Please have a look.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 17, 2023

This is great, thank you! By and large this even looks like an improvement, don't you think?

@jensmaurer jensmaurer marked this pull request as draft December 18, 2023 07:05
@jensmaurer
Copy link
Member Author

jensmaurer commented Dec 18, 2023

Major update; now all mentions of "must" (except in a literal string in an example) are gone.

@tkoeppe, are we good now?

@jensmaurer jensmaurer marked this pull request as ready for review December 18, 2023 16:08
@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 18, 2023

Great! But please note that we can't say "required" as per drafting directives, since that's just a synonym for "shall" :-(

@jensmaurer
Copy link
Member Author

jensmaurer commented Dec 18, 2023

Yes, but "required" is mostly in Annex C, not directly in notes, so maybe they don't notice.

(Frankly, rephrasing Annex C to avoid "required" is a major undertaking, given that it wants to highlight differences between rules.)

source/compatibility.tex Outdated Show resolved Hide resolved
source/compatibility.tex Outdated Show resolved Hide resolved
@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 12, 2024

I'll rebase and apply this PR after the IS has shipped. I'm pushing additonal changes I made to the IS back into this PR, too, so we don't lose them.

@tkoeppe tkoeppe mentioned this pull request Jan 12, 2024
Fixes ISO/CS 037 (C++23 DIS).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

**-037 Review "must"
3 participants