Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "smaller" with "lower" and "larger" with "greater"? #6747

Open
Eisenwave opened this issue Dec 27, 2023 · 1 comment · May be fixed by #6752 or #6776
Open

Replace "smaller" with "lower" and "larger" with "greater"? #6747

Eisenwave opened this issue Dec 27, 2023 · 1 comment · May be fixed by #6752 or #6776

Comments

@Eisenwave
Copy link
Contributor

Eisenwave commented Dec 27, 2023

I've noticed that [algorithms] contains numerous uses of "smaller" and "larger" instead of "lesser" and "greater", or "smallest" and "largest" instead of "least" and "greatest". For example:

Returns: The larger value. Returns the first argument when the arguments are equivalent.
- [alg.min.max] p10

This is surprising and doesn't follow mathematical convention, where you typically speak of "greatest common divisor", "least common multiple", or "lower of two values", not in terms of "smaller" and "larger", which are reminiscent of physical size comparisons. This language is also inconsistent with:

  • std::gcd (can't mean largest common multiple)
  • < (the less-than operator and Unicode LESS-THAN SIGN)
  • > (the greater-than operator and Unicode GREATER-THAN SIGN)
  • std::xxx_ordering::greater and std::xxx_ordering::less
    -std::less and std::greater

With 186 uses, "greater" is much more common in the standard than "larger", at 25. I think we should use consistent language. The standard library symbol names are pretty consistent in using less/great-terminology, but the prose is frequently breaking this convention.

Suggested Fix

Since the words are synonyms and there is no possible ambiguity caused or resolved, we can simply search/replace these terms:

-The larger value.
+The greater value.
@frederick-vs-ja
Copy link
Contributor

As noted in #6776 (comment), it's probably wrong to specify these algorithms with "smaller", "lower", "larger", or "greater".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants