New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[alg.min.max] Reword min/max/minmax in modern style #6776
base: main
Are you sure you want to change the base?
Conversation
This is all editorial, but probably a big enough change that LWG should sign off on it anyway. |
This doesn't exactly address #6747, which wants to replace "smaller" and "larger" with "lesser" and "greater". I want to get rid of the terms altogether and more directly explain what these algorithms do with a custom predicate and projection. In no way does (But yes - thanks - the issue and PR do seem to be at least related.) |
Right. Closes #6747.
Closes #6752. |
... to clarify the meaning of "smaller"/"smallest"/"larger"/"largest" with a custom comparison predicate and/or projection.
@@ -8724,19 +8724,20 @@ | |||
\end{itemdecl} | |||
|
|||
\begin{itemdescr} | |||
\pnum | |||
Let \tcode{comp} be \tcode{less\{\}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether this part is editorial for legacy std
versions. Since less{}
is more determinate than the built-in operation when the comparison between pointers is involved.
... to clarify the meaning of "smaller"/"smallest"/"larger"/"largest" with a custom comparison predicate and/or projection by effectively replacing those terms with code.
Closes #6747.
Closes #6752.