Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #6786

Merged
merged 1 commit into from Jan 27, 2024
Merged

Fix CI #6786

merged 1 commit into from Jan 27, 2024

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Jan 27, 2024

v3 uses deprecated Node.js version.

@jwakely
Copy link
Member Author

jwakely commented Jan 27, 2024

See the warnings at https://github.com/cplusplus/draft/actions/runs/7676986001 about the deprecated version (although I'm sure they were showing as errors on the #6784 PR 20 minutes ago 😕 )

@jwakely
Copy link
Member Author

jwakely commented Jan 27, 2024

Ah no, this workflow action failed, and I thought the warnings shown there were the cause.

Anyway, it's good to update to actions/checkout@v3 and stop those warnings. It seems to work fine for our Actions workflows.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update "actions/upload-artifact" to v4, too (at the bottom of the file).

Could you include this in this patch, please?

@jwakely
Copy link
Member Author

jwakely commented Jan 27, 2024

Will do

The old versions use a deprecated Node.js version.
@jensmaurer jensmaurer merged commit f350a0f into cplusplus:main Jan 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants