Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need Annex C entry for hexfloat #680

Closed
timsong-cpp opened this issue Apr 7, 2016 · 5 comments
Closed

Need Annex C entry for hexfloat #680

timsong-cpp opened this issue Apr 7, 2016 · 5 comments

Comments

@timsong-cpp
Copy link
Contributor

The change to the pp-number production necessitated by the introduction of hexadecimal floating point literals can break valid C++14 code:

long double operator""_p(long double);
auto x = 0e1_p+0; // parsed as 0e1_p + 0 in C++14
                  // parsed as a single pp-number instead in C++17 (and so ill-formed)
@zygoloid
Copy link
Member

zygoloid commented Apr 7, 2016

There's an incompatibility with C++98 too:

#define X(a) b##a
int b0p = X(0p+0); // OK in C++98, ill-formed in C++17

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 21, 2016

@zygoloid: Do you want me to draft the change?

@zygoloid
Copy link
Member

@tkoeppe That'd be great, yes please!

@tkoeppe tkoeppe mentioned this issue Apr 21, 2016
Merged
@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 21, 2016

@zygoloid: PHAL

@deanturpin deanturpin mentioned this issue May 3, 2016
Closed
@deanturpin deanturpin mentioned this issue Jun 2, 2016
Closed
@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 9, 2016

This is completed and can be closed.

@jwakely jwakely closed this as completed Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zygoloid @jwakely @tkoeppe @timsong-cpp