[temp.func.order] Specify to only add extra first argument if needed CWG2834 #6808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwiegley could you take a look, or recommend someone who can take a look? |
|
I haven't been involved with the C++ standard for 10 years now, I do not have any current recommendations. |
|
Please squash the commits and force-push. This looks like a CWG defect to me. |
…t if we don't have an explicit object argument In [temp.func.order] paragraph 3, it is written that we need to add a new first parameter for all member functions for the purposes of template deduction. However, it only makes sense if we don't have an explicit object parameter. If we have an explicit object parameter, we shouldn't add a new (implicit) first parameter because our first parameter is explicitly written.
|
@jensmaurer |
|
@jensmaurer |
|
This open cwg defect solves the same problem, by suggesting the same change (and some more for static member functions). So I think my change does not need to be a separate thing on its own. |
jensmaurer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In [temp.func.order] paragraph 3, it is written that we need to add a new first parameter for all member functions for the purposes of template deduction. However, it only makes sense if we have an implicit object parameter.
If we don't have an implicit object parameter, we shouldn't add a new first parameter because all of our parameters explicitly are written.