[format.parse.ctx] add comma before 'which' #6816
Conversation
There was a problem hiding this comment.
I don't agree that without the comma it suggests "the true which". The definite article is not implicit there, and adding it changes the meaning completely. I do think this is a slight improvement, but the same change should be done on line 17383. Change both, or neither.
We could even move the explanation into a note:
[Note: Calling this function when
indexing_ == manualistrueindicates mixing of ... ]
So the normative part just says what+when it throws, and the note explains why the condition is an error. Just adding commas is fine though.
Eisenwave
force-pushed
the
which-comma
branch
from
f874157
to
58635e6
Compare
|
I favor the solution which converts the non-normative part into a note. Also, I believe that it's sufficient to say "This indicates ...". Firstly, the stakes are low since this isn't normative wording anyway. Secondly, no matter whether the reader thinks that "This" refers to
the reading is correct. I don't think the verbosity of "Calling this function when |
Normally, you would write a comma here.
Saying
suggests that
index == manualis thetruewhich ...This wouldn't make sense since there is only one
true, which makes it more correct to write a comma here. Of course, the sentence is unambiguous one way or the other; this is purely a readability improvement.