Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[format.parse.ctx] add comma before consisting #6817

Merged
merged 1 commit into from Feb 22, 2024
Merged

[format.parse.ctx] add comma before consisting #6817

merged 1 commit into from Feb 22, 2024

Conversation

Eisenwave
Copy link
Contributor

It is more correct to write a comma here. The current wording suggests that

An instance of basic_fomat_parse_context holds the one format string parsing state (of many parsing states) which happens to consist of ...

What the sentence is actually trying to express is

An instance of basic_format_parse_context holds the the format string parsing state; this state consists of ...

@jensmaurer jensmaurer merged commit a5825b1 into cplusplus:main Feb 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eisenwave @jwakely @jensmaurer