Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[allocator.adaptor] consolidate memory utilities #683

Merged
merged 1 commit into from Jun 8, 2016

Conversation

AlisdairM
Copy link
Contributor

This patch simply moves the scoped allocator clause to
be adjacent to the other memory and allocator clauses
for a more consistent sub-organization of clause 20.

The patch looks pretty awful thanks to the diff
algorithm treating it a lot of interspersed edits,
where in fact is way a single cut/paste for the
bulk of the test (plus a second one-liner for the
clause 20 table of contents).

@zygoloid
Copy link
Member

Makes sense. Can you rebase? Your change to move compile-time integer sequences conflicts with this one.

@AlisdairM
Copy link
Contributor Author

If I rebase, is the preference to apply a 'force push' to my fork, as otherwise the histories are incompatible?

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 13, 2016

@AlisdairM: Yes. Everyone except for cplusplus should only ever rebase and force-push, and never merge. Merging is the sole prerogative of the main fork.

@AlisdairM
Copy link
Contributor Author

rebased within the last hour, and force-pushed to my branch - it should land cleanly again.

@AlisdairM
Copy link
Contributor Author

Waiting for #704 to land before resolving conflicts and rebasing again.

This patch simply moves the scoped allocator clause to
be adjacent to the other memory and allocator clauses
for a more consistent sub-organization of clause 20.

The patch looks pretty awful thanks to the diff
algorithm treating it as a lot of interspersed edits,
where in fact is way a single cut/paste for the bulk
of the test (plus a second one-liner for the clause 20
table of contents).
@AlisdairM
Copy link
Contributor Author

Rebased and pushed again; ready for review.

@jwakely
Copy link
Member

jwakely commented Jun 8, 2016

N.B. git diff --diff-algorithm=histogram gives much better diffs for this kind of change -- in this case it's perfect, showing simply the one-liner and the large chunk moved. You can't get github to show that though, so you need to fetch the branch or apply the patch locally to diff it locally, but it won't show this diff in the web UI so you have to do that anyway.

The change looks good to me.

@jwakely jwakely merged commit 403d679 into cplusplus:master Jun 8, 2016
@AlisdairM AlisdairM deleted the consolicate_allocators branch June 8, 2016 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants