Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[headers] Strike 'C standard library headers' and turn paragraph into note #6832

Merged
merged 1 commit into from Mar 1, 2024
Merged

[headers] Strike 'C standard library headers' and turn paragraph into note #6832

merged 1 commit into from Mar 1, 2024

Conversation

Eisenwave
Copy link
Contributor

Fixes #6789.

Furthermore, this paragraph has no normative effect and can be turned into a note. It's merely a "this other section specifies ..." paragraph.

@jwakely
Copy link
Member

jwakely commented Mar 1, 2024

NACK. We have lots of "semi-normative" introductory paragraphs like this, they shouldn't be notes.

@Eisenwave
Copy link
Contributor Author

Eisenwave commented Mar 1, 2024 •
edited

NACK. We have lots of "semi-normative" introductory paragraphs like this, they shouldn't be notes.

Fine, I won't die on this hill. I've actually changed it back via force-push already; looks like GitHub isn't picking up on the new commit yet.

@Eisenwave Eisenwave force-pushed the headers-note branch 2 times, most recently from 4fcf363 to 622701d Compare March 1, 2024 15:31
@jensmaurer
Copy link
Member

@jwakely , in #6789 you suggested what this pull request does.

Have you changed your mind, or is this pull request good as-is (ignoring the suggestion about introducing more notes)?

jwakely
jwakely approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change to the cross-ref, I just didn't like changing it to a note.

@jensmaurer jensmaurer merged commit ceff4ea into cplusplus:main Mar 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[headers] has incorrect name for subclause xref
3 participants
@Eisenwave @jwakely @jensmaurer