Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta.unary.prop] Consistent formatting for 'void' #684

Merged
merged 2 commits into from May 30, 2016

Conversation

AlisdairM
Copy link
Contributor

This patch addresses #544.
Update all use of 'void' in type traits tables to use the codified
form \tcode{void}. There was one use of the phrase "void types"
that I deliberately chose to not touch.

A second issue I stumbled over in this edit was inconsistent use
of cv-qualified vs. \cv-qualfied. The latter seemed preferable,
so I applied that formatting consistently through this file for
all uses of cv-qualified that were not otherwise participating
in mark-up.

@@ -2133,7 +2133,7 @@

\pnum
A program that necessitates the instantiation of template \tcode{optional} for
a reference type, or for possibly cv-qualified types \tcode{in_place_t} or
a reference type, or for possibly \cv-qualified types \tcode{in_place_t} or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cv should not be italicized except when referencing a metavariable representing a set of cv-qualifiers. That is: "cv-qualified" means "qualified with the set of qualifiers named cv", whereas "cv-qualified" means "qualified with some unspecified cv-qualifiers". See [basic.type.qualifier]/5.

@AlisdairM
Copy link
Contributor Author

So I should consistently strike that leading '' on all the cv-qualified terms in those tables, rather than consistently add it? (i.e., not just for the one line that you highlighted - think I am stating the obvious, but checking before I push an update).

This patch address cplusplus#544.
Update all use of 'void' in type traits tables to use the codified
form \tcode{void}.  There was one use of the phrase "void types"
that I deliberately chose to not touch.

A second issue I stumbled over in this edit was inconsistent use
of cv-qualified vs. \cv-qualfied.  The latter seemed preferable,
so I applied that formatting consistently through this file for
all uses of cv-qualified that were not otherwise participating
in mark-up.
@AlisdairM
Copy link
Contributor Author

Rebased, and consistently struct the \ on "(potentially \cv-qualified)" throughout this file. Force-pushed an update that should be clean to land, assuming it passes muster.

@zygoloid zygoloid merged commit 8c1fef8 into cplusplus:master May 30, 2016
@AlisdairM AlisdairM deleted the type_traits_void_markup branch June 1, 2016 20:31
FrankHB pushed a commit to FrankHB/draft that referenced this pull request Jul 9, 2016
* [meta.unary.prop] Consistent formatting for 'void'

Fixes cplusplus#544.

Update all use of 'void' in type traits tables to use the codified
form \tcode{void}.  There was one use of the phrase "void types"
that I deliberately chose to not touch.

A second issue I stumbled over in this edit was inconsistent use
of cv-qualified vs. \cv-qualfied.  The latter seemed preferable,
so I applied that formatting consistently through this file for
all uses of cv-qualified that were not otherwise participating
in mark-up.

* Fix formatting of cv-qualifiers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants