[pairs.pair] Replace std::forward with std::move where equivalent
#6849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisenwave
changed the title
std::forward with std::move where equivalent
|
Nevermind, I have missed the possibility of reference members. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
std::forwardfor the following assignment operators is unnecessary:operator=(pair&& p)operator=(pair&& p) const.In both cases, we know 100% that the types of
this->firstandp.firstand the type ofthis->secondandp.secondmatch, and we are working with an rvalue reference, not a forwarding reference.In such cases, it's not necessary to use
std::forward, and it arguably misleads the reader into thinking that this is ever copying instead of moving, which isn't the case (unless the two are equivalent).