[unique.ptr.special] prefer use of common_type_t #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preferred style since C++14 is to use the _t alias rather than the trait::type formulation for transformation traits. As a second fix, the types in the common_type instantiation are, in turn, dependant types so require a leading typename keyword. I double-checked elsewhere and we are consistent to use typename where requrired inside other expressions, even though it is frequently omitted when the named type is used within the surrounding English text.
FrankHB
pushed a commit
to FrankHB/draft
that referenced
this pull request
Jul 9, 2016
The preferred style since C++14 is to use the _t alias rather than the trait::type formulation for transformation traits. As a second fix, the types in the common_type instantiation are, in turn, dependant types so require a leading typename keyword. I double-checked elsewhere and we are consistent to use typename where requrired inside other expressions, even though it is frequently omitted when the named type is used within the surrounding English text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preferred style since C++14 is to use the _t alias
rather than the trait::type formulation for transformation
traits. As a second fix, the types in the common_type
instantiation are, in turn, dependant types so require a
leading typename keyword. I double-checked elsewhere and
we are consistent to use typename where requrired inside
other expressions, even though it is frequently omitted
when the named type is used within the surrounding
English text.