Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LWG motion 10] P2542R8 views::concat #6917

Merged
merged 1 commit into from Apr 16, 2024
Merged

[LWG motion 10] P2542R8 views::concat #6917

merged 1 commit into from Apr 16, 2024

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Mar 30, 2024 •
edited by jensmaurer

@burblebee
Copy link
Contributor Author

The build is failing with the following errors due to workarounds for Overfull issues:

Run ../tools/check-output.sh
::error concept bidirectional has no definition
::error concept concat-is-bidirec\-tional has no definition
::error concept concat-is-ran\-dom-access has no definition
::error concept cess has no definition
Error: Process completed with exit code 1.

The offending bits of source are:

\exposconcept{concat-is--\linebreak{}bidirectional}<Const, Views...>}
\exposconcept{concat-is-bidirec\-tional}
\exposconcept{concat-is-ran\-dom-access}
\exposconcept{concat-is-random-ac-\linebreak{}cess}<Const, Views...>}

Any ideas for how to make the build happy?

@jensmaurer
Copy link
Member

Use \exposconceptx . See macros.tex

@burblebee burblebee marked this pull request as ready for review March 31, 2024 05:36
@burblebee burblebee marked this pull request as draft March 31, 2024 05:37
@burblebee
Copy link
Contributor Author

burblebee commented Mar 31, 2024 •
edited

Use \exposconceptx . See macros.tex

Thank you! But ...

Ignoring the mac install issues, now getting other failures that I don't understand :

Run ../tools/check-output.sh
::error concept hyperpage[1](https://github.com/cplusplus/draft/actions/runs/8496095034/job/23273078012?pr=6917#step:11:1)237 has no definition
::error concept hyperpage1[2](https://github.com/cplusplus/draft/actions/runs/8496095034/job/23273078012?pr=6917#step:11:2)35 has no definition
Error: 476:  v.push_back(i*2+1);                    -- concept name without markup
Error: 4450:bool(invoke(pred, invoke(proj1, *(i + n)), invoke(proj2, *(first2 + n)))) -- concept name without markup
Error: 6627:bool(invoke(comp, invoke(proj, *(i + n)), invoke(proj, *i))) -- concept name without markup
Error: 9961:@\placeholdernc{GENERALIZED_SUM}@(binary_op1, init, binary_op2(*i, *(first2 + (i - first1))), ...) -- concept name without markup
Error: 11[3](https://github.com/cplusplus/draft/actions/runs/8496095034/job/23273078012?pr=6917#step:11:3)2:const int i = 2; -- concept name without markup
[...]

@burblebee burblebee marked this pull request as ready for review March 31, 2024 05:56
@jensmaurer
Copy link
Member

Hm... I can reproduce those errors. Looks like the .ind format changed a little. But why does this appear with exactly this pull request, and none of the others?

@jensmaurer
Copy link
Member

jensmaurer commented Apr 3, 2024 •
edited

Ah, someone refers to a concept called just "i", and that screws up everything. On page 1236.

@jensmaurer
Copy link
Member

jensmaurer commented Apr 3, 2024 •
edited

You're using \exposconceptx incorrectly. It has two parameters, not just one. Example:

\exposconceptx{concat-is-ran\-dom-access}{concat-is-random-access}

Please fix.

@burblebee
Copy link
Contributor Author

You're using \exposconceptx incorrectly. It has two parameters, not just one. Example:

Ah! Thank you! fixed and pushed.

@tkoeppe tkoeppe force-pushed the motions-2024-03-lwg-10 branch 2 times, most recently from 8cef76b to 058da8a Compare April 16, 2024 10:37
@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 16, 2024

Thank you very much!

@tkoeppe tkoeppe merged commit 2bb990d into main Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2024-03 LWG Motion 10] views::concat P2542 R8 views::concat
3 participants
@burblebee @jensmaurer @tkoeppe