Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly render packages installs #6923

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CosminGGeorgescu
Copy link

No description provided.

@jensmaurer
Copy link
Member

This adds additional (duplicate) colons and adds trailing whitespace in one instance.

The former seems to satisfy https://docutils.sourceforge.io/docs/user/rst/quickref.html#literal-blocks , but the latter is a bit undermotivated. Care to elaborate?

@CosminGGeorgescu
Copy link
Author

but the latter is a bit undermotivated

Just a tabbing tic, seemed to go over my head when reviewing.

I can add a commit removing it (a bit of an eye sore), squash them together (which would need a force :[ ) or close it and let this be a post-it note for the beholder to squeeze in their next PR.

@jwakely
Copy link
Member

jwakely commented Apr 9, 2024

Please force push, there's no problem with doing that in a pull request. Nobody else is fetching this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants