[expos.only.entity] Add missing \expos for two exposition-only names #6924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure only comments
jensmaurer
requested changes
Apr 16, 2024
There was a problem hiding this comment.
I think we want an \expos comment on every line where we introduce (for the first time, e.g. in a header) an exposition-only name, regardless of the surroundings.
So, this particular comment should move one line up, and the other two names should also get an \expos comment.
|
I agree with Jens. |
hewillk
changed the title
|
Looks better. Please squash the two commits and force-push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..Also fixed an issue where the first exposition-only comment wasn't quite aligned.