[zombie.names] Turn lists of zombie names into tables #6925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't reviewed the diff carefully, but I like the general idea. |
jensmaurer
approved these changes
Apr 17, 2024
AlisdairM
force-pushed
the
zombie_tables
branch
2 times, most recently
from
dd1fde3
to
667171f
Compare
timsong-cpp
reviewed
Apr 17, 2024
|
do not merge until I address the comment above by @timsong-cpp |
AlisdairM
force-pushed
the
zombie_tables
branch
from
667171f
to
26cd5bb
Compare
|
The latest commit should have squashed updates that explicitly reference the tables, and give them appropriate |
jensmaurer
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6898
As the list of zombie names has grown so long, it is hard to check without scrolling. Rendering as a table makes it easier to read in one place, as well as saving on our page count!
Pre-emptively turned all the other zombie name lists into tables too, for consistency. We have precedent for such short tables with the table of contextual keywords.