[memory.syn][specialized.algorithms] Prefer trailing returns on complex signatures #6964
+107
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex signatures This proposed change follows the observation that when function template signatures get complicated, especially with long names for return types, and non-trivial requires clauses, it can be very hard to spot the function name and return type among the sea of tokens, in order to start mentally parsing the function. Here we propose using the trailing return type form of function declaration in those cases, and apply it consistently to the special algorithms in the '<memory>' header as a non-trivial sample size to gauge interest in a more complete PR that would cover the whole ranges library.
AlisdairM
force-pushed
the
trailing_return_for_constrained_templates
branch
from
fd4d672 to
56fb956
Compare
jensmaurer
reviewed
May 7, 2024
There was a problem hiding this comment.
I must say, I'm underimpressed. Some changes seem outright non-improvements, such as I f(...) -> auto f(...) -> I.
pair<ForwardIterator, NoThrowForwardIterator> seems to be the most complicated return type I can spot, and that doesn't feel overly complicated.
In any case, I want the opinion of LWG on a global change like that.
(If we feel the name of the function isn't sufficiently highlighted, maybe we can do something on the typographical level, e.g. make it bold.)
@jwakely ?
wg21bot
added
the
needs rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change follows the observation that when function template signatures get complicated, especially with long names for return types, and non-trivial requires clauses, it can be very hard to spot the function name and return type among the sea of tokens, in order to start mentally parsing the function.
Here we propose using the trailing return type form of function declaration in those cases, and apply it consistently to the special algorithms in the
<memory>header as a non-trivial sample size to gauge interest in a more complete PR that would cover the whole ranges library.