Skip to content

[print.syn] Show locking functions in the synopsis of <print> #6971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented May 12, 2024

The changes seem missed in #6908.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@frederick-vs-ja

This comment was marked as resolved.

@Dani-Hub
Copy link
Member

Currently there're no

* `void vprint_unicode_locking(string_view fmt, format_args args);` and

* `void vprint_nonunicode_locking(string_view fmt, format_args args);`

overloads (where stdout should be the omitted FILE* argument).

Should there be an LWG issue for this? @jwakely @Dani-Hub

I noticed the omission in P3107R5 as well, but it looked deliberate to me. @jwakely What do you think?

@jwakely
Copy link
Member

jwakely commented May 13, 2024

We don't want convenience functions for using those with stdout. They're low level, internal implementation details. They don't need to be convenient.

@jensmaurer
Copy link
Member

I notice that the paper P3107R5 did not show a header where to add those _locking functions.

@jwakely , is the change proposed here (not the add-on stdout overloads) editorially-obvious?

@jwakely
Copy link
Member

jwakely commented May 13, 2024

Yes, I think the new functions should be in the synopsis.

@jensmaurer
Copy link
Member

@jwakely , care to approve, then?

@tkoeppe tkoeppe merged commit 8d8861c into cplusplus:main Jul 28, 2024
2 checks passed
@frederick-vs-ja frederick-vs-ja deleted the vprint-locking branch July 28, 2024 00:50
@frederick-vs-ja
Copy link
Contributor Author

@tkoeppe @jwakely This PR is outdated due to P3235R3. Could you review the new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants