Skip to content

Reference comments missing from [memory.polymorphic.allocator.class] synopsis #699

Closed
@burblebee

Description

@burblebee
Contributor

Methods in synopsis are missing comments and references to definitions.
Comments should precede each method group with:
// <ref>, descrition:

Also, is "Specializations for pair using piecewise construction" the right description for the methods that follow it?

Activity

jwakely

jwakely commented on Apr 14, 2016

@jwakely
Member

Also, is "Specializations for pair using piecewise construction" the right description for the methods that follow it?

They're overloads not specializations, so maybe "Overloads for piecewise construction of pairs." (The term is defined in [pairs.pair]p14).

self-assigned this
on Apr 14, 2016
burblebee

burblebee commented on Apr 14, 2016

@burblebee
ContributorAuthor

Or should "Specializations for pair using piecewise construction" be reworded as a note in the details of method "void construct(pair<T1,T2>* p, piecewise_construct_t, ...)"? That's how we resolved the other incorrect comment "Return a default-constructed allocator (no allocator propagation)" before "select_on_container_copy_construction()". Thoughts on how to word the note?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @jwakely@burblebee

      Issue actions

        Reference comments missing from [memory.polymorphic.allocator.class] synopsis · Issue #699 · cplusplus/draft