Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference comments missing from [memory.polymorphic.allocator.class] synopsis #699

Closed
burblebee opened this issue Apr 14, 2016 · 2 comments
Closed

Reference comments missing from [memory.polymorphic.allocator.class] synopsis #699

burblebee opened this issue Apr 14, 2016 · 2 comments
Assignees
@burblebee

Comments

@burblebee
Copy link
Contributor

Methods in synopsis are missing comments and references to definitions.
Comments should precede each method group with:
// <ref>, descrition:

Also, is "Specializations for pair using piecewise construction" the right description for the methods that follow it?
@jwakely
Copy link
Member

jwakely commented Apr 14, 2016

Also, is "Specializations for pair using piecewise construction" the right description for the methods that follow it?

They're overloads not specializations, so maybe "Overloads for piecewise construction of pairs." (The term is defined in [pairs.pair]p14).

@burblebee burblebee self-assigned this Apr 14, 2016
@burblebee
Copy link
Contributor Author

Or should "Specializations for pair using piecewise construction" be reworded as a note in the details of method "void construct(pair<T1,T2>* p, piecewise_construct_t, ...)"? That's how we resolved the other incorrect comment "Return a default-constructed allocator (no allocator propagation)" before "select_on_container_copy_construction()". Thoughts on how to word the note?

@geoffromer geoffromer mentioned this issue Apr 15, 2016
Closed
FrankHB pushed a commit to FrankHB/draft that referenced this issue Jul 9, 2016
@FrankHB
[memory.polymorphic.allocator] Add references and add/fix comments in…
b66baa8 
… synopsis (cplusplus#699)

Fixes cplusplus#699.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@burblebee burblebee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwakely @burblebee