Skip to content

[deque, forward.list, list, vector] Fix instances of "FooInsertable into *this" #7136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

Quuxplusone
Copy link
Contributor

Fixes #7133

…nto *this"

Fixes cplusplus#7133
@@ -6716,7 +6716,7 @@
\begin{itemdescr}
\pnum
\expects
\tcode{T} is \oldconcept{DefaultInsertable} into \tcode{*this}.
\tcode{T} is \oldconcept{DefaultInsertable} into \tcode{deque}.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change T to value_type in each case as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's necessary (and would require changes in places that this PR doesn't already touch).

@tkoeppe tkoeppe merged commit 407c552 into cplusplus:main Jul 29, 2024
2 checks passed
@Quuxplusone Quuxplusone deleted the into-x branch July 29, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad phrasing "FooInsertable into *this"
3 participants