[string.view.comparison] Fix index for basic_string_view operators #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first issue is that operator<< does not group in the index with other definitions for operator<<, which use an index key of operator\shl. The second issue is that operator<< was the only operator indexed under the 'basic_string_view' key, where the precedent fro basic_string and other types is that the free-function operators are still indexed under their respective class entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first issue is that operator<< does not group in the index with
other definitions for operator<<, which use an index key of
operator\shl.
The second issue is that operator<< was the only operator indexed
under the 'basic_string_view' key, where the precedent fro basic_string
and other types is that the free-function operators are still indexed
under their respective class entry.