[18-20,27] Prefer to use 'override' where appropriate #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes consistent use of the 'override' contextual keyword for every member function (other than destructors) that overrides a virtual function in one of its base classes. In general, this came down to one of three cases: 1) the 'what' function for an exception class 2) the allocation functions of a memory resource 3) the implementation methods of a stream buffer. As far as I can tell, all other virtual function declarations in the standard library are intended as customization points for users, and are not overriden in the standard itself.
|
@AlisdairM: Please revise the commit and PR message; there's a stray closing bracket. |
AlisdairM
changed the title
FrankHB
pushed a commit
to FrankHB/draft
that referenced
this pull request
Jul 9, 2016
This patch makes consistent use of the 'override' contextual keyword for every member function (other than destructors) that overrides a virtual function in one of its base classes. In general, this came down to one of three cases: 1) the 'what' function for an exception class 2) the allocation functions of a memory resource 3) the implementation methods of a stream buffer. As far as I can tell, all other virtual function declarations in the standard library are intended as customization points for users, and are not overridden in the standard itself. Fixes cplusplus#751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes consistent use of the 'override' contextual
keyword for every member function (other than destructors)
that overrides a virtual function in one of its base classes.
In general, this came down to one of three cases:
As far as I can tell, all other virtual function declarations
in the standard library are intended as customization points
for users, and are not overriden in the standard itself.
This pull request addresses #751