Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NULL with "null pointer value" #769

Merged
merged 2 commits into from Jun 23, 2016
Merged

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Jun 23, 2016

Fixes issue #52.

Diff:

image

image

@zygoloid
Copy link
Member

This is still wrong -- we should say "an argument that is a null pointer value". We don't care how the null pointer value was written in the source code. But maybe fixing that is a lost cause. Thoughts?

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Jun 23, 2016

PTAL, will upload screenshot shortly.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Jun 23, 2016

New screenshots:

image

image

@tkoeppe tkoeppe changed the title Replace NULL with nullptr Replace NULL with "null pointer value" Jun 23, 2016
@zygoloid zygoloid merged commit 1e1f81c into cplusplus:master Jun 23, 2016
@tkoeppe tkoeppe deleted the null branch June 23, 2016 19:43
@timsong-cpp
Copy link
Contributor

@zygoloid But neither NULL nor nullptr is a null pointer value. The parameter has a null pointer value because it is initialized by a null-pointer-constant argument, but the argument need not be a null pointer value.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Jun 23, 2016

@timsong-cpp: yeah... I'm not sure. Even the wording "an mbstate_t* argument" is odd. It suggests that the argument already has pointer type. Meh, maybe that's good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants